Repository navigation
Add missing type hints & Force type hints - Part 3 - #4805
Merged
neersighted merged 11 commits intoNov 23, 2021
Merged
neersighted merged 11 commits into
neersighted merged 11 commits into
Conversation
finswimmer
force-pushed
the
improvement/force-type-hints_part-3
branch
from
November 20, 2021 16:44
84d1465 to
ab8a38b
Compare
finswimmer
force-pushed
the
improvement/force-type-hints_part-3
branch
from
November 21, 2021 07:26
c7d4805 to
e1a1859
Compare
finswimmer
changed the title
finswimmer
marked this pull request as ready for review
November 21, 2021 08:28
neersighted
requested changes
Nov 23, 2021
neersighted
left a comment
neersighted
left a comment
Member
There was a problem hiding this comment.
Minor nits over the lint config -- overall LGTM. Today I learned about the Pytest parameterized kwargs splitting a string on "," -- I've only ever used the list syntax myself.
| max-line-length = 88 | ||
| ban-relative-imports = true | ||
| inline-quotes = double | ||
| mypy-init-return = True |
Member
There was a problem hiding this comment.
Let's add a comment here explaining which plugin this corresponds to / maybe a doc link? Also let's go for a lower case true since that's what we've done in the rest of the file.
| - flake8-type-checking==1.1.0 | ||
| - flake8-typing-imports==1.11.0 | ||
| - pep8-naming==0.12.1 | ||
| - flake8-annotations |
Member
There was a problem hiding this comment.
Let's lock this to a version and alphabetize it.
…, tests.utils.test_env_site, tests.utils.test_exporter
…ests.utils.test_password_manager, tests.utils.test_patterns, tests.utils.test_pip, tests.utils.setup_reader
finswimmer
force-pushed
the
improvement/force-type-hints_part-3
branch
from
November 23, 2021 06:52
a661bca to
5214721
Compare
neersighted
approved these changes
Nov 23, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the final part of a series which add missing type hints to both package code and test code. Furthermore flake-annotations is added as a flake8 plugin to enforce type hints in the future.